Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uondrs_ada config file : WIP #715

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

ShahNiraj
Copy link


name: New Config : uondrs_ada
about: A new cluster config. I wish to add a new nfcore config file "uondrs_ada"

First config
Added Profile config names for nf-core/configs
First nf-core config.
Added 'uondrs_ada.md' in the pipeline specific documentation section of this page
Added "uondrs_ada" to the profiles section
@@ -296,6 +296,9 @@ Currently documentation is available for the following pipeline:

- viralrecon
- [genomes](docs/pipeline/viralrecon/genomes.md)

- rnaseq
- [uondrs_ada](docs/pipeline/rnaseq/uondrs_ada.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path doesn't seem to exist?

process {

// resources for default process execution
withLabel:process_low {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list of process labels isn't exhaustive I think. Do you need to define them? Normally we've been recommending setting max resources in params (https://nf-co.re/docs/usage/getting_started/configuration#max-resources).

Nextflow has changed for the better since but that haven't yet reached everywhere, so I still think that's a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants