Skip to content

Compare to given checksum in input - #35

Merged
apeltzer merged 19 commits into
nf-core:devfrom
delfiterradas:compare_checksum
Jun 30, 2026
Merged

Compare to given checksum in input#35
apeltzer merged 19 commits into
nf-core:devfrom
delfiterradas:compare_checksum

Conversation

@delfiterradas

@delfiterradas delfiterradas commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #32

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/datasync branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@delfiterradas delfiterradas self-assigned this Jun 18, 2026
@apeltzer
apeltzer self-requested a review June 25, 2026 13:01
@delfiterradas
delfiterradas marked this pull request as ready for review June 29, 2026 18:40
@delfiterradas
delfiterradas requested a review from atrigila June 29, 2026 18:41
atrigila
atrigila reviewed Jun 29, 2026
View reviewed changes

@atrigila atrigila left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Please do not forget to update changelog.

Comment thread modules/local/comparechecksum/environment.yml Outdated
Comment thread modules/local/comparechecksum/meta.yml Outdated
Comment thread modules/local/comparechecksum/templates/comparechecksum.R Outdated
Comment thread modules/local/comparechecksum/meta.yml Outdated
atrigila
atrigila approved these changes Jun 29, 2026
View reviewed changes

@atrigila atrigila left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, we can then modify this in next iterations to either make this an nf-core module or use any other available module that has a similar function.

Follow up ticket: #39

apeltzer
apeltzer approved these changes Jun 30, 2026
View reviewed changes

@apeltzer apeltzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apeltzer
apeltzer merged commit 04eae40 into nf-core:dev Jun 30, 2026
16 of 18 checks passed
@delfiterradas delfiterradas mentioned this pull request Aug 20, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apeltzer apeltzer apeltzer approved these changes
@atrigila atrigila atrigila approved these changes

Assignees

@delfiterradas delfiterradas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Compare to given checksum in input

3 participants

@delfiterradas @apeltzer @atrigila