Skip to content

Conversation

@matq007
Copy link
Member

@matq007 matq007 commented Nov 29, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/marsseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Nov 29, 2024

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit c9a702e

+| ✅ 211 tests passed       |+
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • included_configs - Pipeline config does not include custom configs. Please add the includeConfig line.

✅ Tests passed:

Run details

  • nf-core/tools version 3.0.2
  • Run at 2025-06-02 12:10:45

@famosab
Copy link

famosab commented Mar 11, 2025

@matq007 Do you need some help to finalize this release? :)

@matq007
Copy link
Member Author

matq007 commented Mar 11, 2025

I just need a PR review, the pipeline is works locally ^_^

@famosab
Copy link

famosab commented Mar 12, 2025

But there are three tests which are marked as required and are not running?

Copy link

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of questions. My main thing would be:

Try to do changes that go into the changelog in small PRs (like a new subworkflow) - these are easily reviewable. To me it seems that many commits went into this release PR but these were not reviewed in the meantime (?).

And use nf-core pipelines bump-version to update to a version for the release. I would also suggest to include the release name in the changelog. https://www.codenamegenerator.com/ can be used for name finding :)

@matq007
Copy link
Member Author

matq007 commented Jun 2, 2025

Hi @famosab, I assume the reason behind failed execution is because of changes from nf-core template which marsseq if quite behind. Would be easier to merge the latest PR to this as well? It will be however a huge PR then, but I can split the this next merging to smaller commit. Let me know what you think.

@famosab
Copy link

famosab commented Jun 2, 2025

I would recommend a PR from a feature branch to dev which incorporates the new changes :) That way each change will be a bit smaller and easier to track?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants