- 
                Notifications
    
You must be signed in to change notification settings  - Fork 5
 
v1.1.0 #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Important! Template update for nf-core/tools v3.0.2
          
 | 
    
| 
           @matq007 Do you need some help to finalize this release? :)  | 
    
| 
           I just need a PR review, the pipeline is works locally ^_^  | 
    
| 
           But there are three tests which are marked as required and are not running?  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of questions. My main thing would be:
Try to do changes that go into the changelog in small PRs (like a new subworkflow) - these are easily reviewable. To me it seems that many commits went into this release PR but these were not reviewed in the meantime (?).
And use nf-core pipelines bump-version to update to a version for the release. I would also suggest to include the release name in the changelog.  https://www.codenamegenerator.com/ can be used for name finding :)
| 
           Hi @famosab, I assume the reason behind failed execution is because of changes from nf-core template which marsseq if quite behind. Would be easier to merge the latest PR to this as well? It will be however a huge PR then, but I can split the this next merging to smaller commit. Let me know what you think.  | 
    
| 
           I would recommend a PR from a feature branch to dev which incorporates the new changes :) That way each change will be a bit smaller and easier to track?  | 
    
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).