-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency upgrade #409
Dependency upgrade #409
Conversation
This PR includes upgrade all dependencies to latest and the removal of reflect-metadata in favor of core-js |
I assume this was closed in favor of #410 |
That's correct. |
The only part that has really changed is the webpack-test.config.js. The CommonsChunkPlugin doesn't play nice with karma and I don't have a clean fix atm. Seems to be a common issue. For the moment I clear the inported plug-ins. Will find a better solution this weekend. By the way, we are using styleUrls and templateUrls, the angular2-template-loader plugin will change it to require at build time if your interested in a PR for that? |
👍 Nice work. For my own project our app is pretty big so I've been avoiding bundling templates in our Angular.js app to help initial load times. If you have a smaller app (or have set up lazy loading) importing |
This PR includes upgrade all dependencies to latest and the removal of reflect-metadata in favor of core-js