Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency upgrade #409

Closed
wants to merge 8 commits into from
Closed

Dependency upgrade #409

wants to merge 8 commits into from

Conversation

jbadeau
Copy link

@jbadeau jbadeau commented Jul 10, 2017

This PR includes upgrade all dependencies to latest and the removal of reflect-metadata in favor of core-js

@jbadeau
Copy link
Author

jbadeau commented Jul 10, 2017

This PR includes upgrade all dependencies to latest and the removal of reflect-metadata in favor of core-js

@jbadeau jbadeau closed this Jul 10, 2017
@aciccarello
Copy link

I assume this was closed in favor of #410

@jbadeau
Copy link
Author

jbadeau commented Jul 10, 2017

That's correct.

@jbadeau
Copy link
Author

jbadeau commented Jul 10, 2017

The only part that has really changed is the webpack-test.config.js. The CommonsChunkPlugin doesn't play nice with karma and I don't have a clean fix atm. Seems to be a common issue. For the moment I clear the inported plug-ins. Will find a better solution this weekend.

By the way, we are using styleUrls and templateUrls, the angular2-template-loader plugin will change it to require at build time if your interested in a PR for that?

@aciccarello
Copy link

aciccarello commented Jul 10, 2017

👍 Nice work. For my own project our app is pretty big so I've been avoiding bundling templates in our Angular.js app to help initial load times. If you have a smaller app (or have set up lazy loading) importing styleUrls & templateUrls makes sense to me. Idk what the maintainers would suggest for this scaffold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants