Skip to content

Conversation

@aphralG
Copy link
Contributor

@aphralG aphralG commented Nov 6, 2025

Proposed changes

Add max_parallel_file_operations to agent config which specifies the number of file operations which will be done in parallel (Default is 5)
Files will now be uploaded and downloaded in parallel during a config apply and upload config operations.

Example of agent config

client:
    grpc:
       max_parallel_file_operations: 10

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Nov 6, 2025
@aphralG aphralG requested a review from a team as a code owner November 6, 2025 10:28
@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Nov 6, 2025
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.40%. Comparing base (c5193ee) to head (3a65aab).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/file/file_manager_service.go 94.11% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1376      +/-   ##
==========================================
+ Coverage   86.28%   86.40%   +0.12%     
==========================================
  Files         102      102              
  Lines       12572    12590      +18     
==========================================
+ Hits        10848    10879      +31     
+ Misses       1248     1232      -16     
- Partials      476      479       +3     
Files with missing lines Coverage Δ
internal/config/config.go 87.19% <100.00%> (+0.07%) ⬆️
internal/config/defaults.go 100.00% <ø> (ø)
internal/config/flags.go 100.00% <ø> (ø)
internal/config/types.go 86.04% <ø> (ø)
internal/file/file_manager_service.go 75.38% <94.11%> (+0.25%) ⬆️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5193ee...3a65aab. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

fs.Int(
ClientGRPCMaxParallelFileOperationsKey,
DefMaxParallelFileOperations,
"Max number of files downloaded or uploaded in parallel",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Max number of files downloaded or uploaded in parallel",
"Maximum number of file downloads or uploads performed in parallel",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants