Add script to check container images' agent versions #1404
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1404 +/- ##
==========================================
+ Coverage 86.24% 86.43% +0.18%
==========================================
Files 102 102
Lines 12603 12603
==========================================
+ Hits 10870 10893 +23
+ Misses 1257 1232 -25
- Partials 476 478 +2 see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
|
||
| for tag in "${FOUND[@]}"; do | ||
| echo ":: ${REGISTRY_URL}/${IMAGE_NAME}:$tag" | ||
| podman pull ${REGISTRY_URL}/${IMAGE_NAME}:$tag > /dev/null 2>&1 |
There was a problem hiding this comment.
Can you add a check to see if docker or podman is installed? Some people might use docker over podman
| echo "Checking images in ${REGISTRY_URL}/${IMAGE_NAME}" | ||
|
|
||
| # Fetch all tags from the remote registry | ||
| skopeo list-tags docker://${REGISTRY_URL}/${IMAGE_NAME} | jq -r '.Tags[]' > all_tags.txt |
There was a problem hiding this comment.
Would it be possible to use the skopeo docker image instead? https://github.com/containers/skopeo/blob/main/install.md#container-images
Would save people having to install skopeo on their machines
There was a problem hiding this comment.
True yeah I'll add that
There was a problem hiding this comment.
Do we want this implemented as a Github workflow in that case?
Proposed changes
Adds a script
check-images.shwhich can check the agent version and nginx version of all image tags matching a pattern.Example:
will return all the tags found for the
agentv3image which match the patternalpine, and run the commands:nginx -vnginx-agent -vChecklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)