Skip to content

feat: Template support for the NGINX HTTP gzip static module #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 8, 2025

Conversation

alessfg
Copy link
Member

@alessfg alessfg commented May 7, 2025

Proposed changes

Add templating support for the ngx_http_gzip_static_module NGINX module. Closes #380.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

@Copilot Copilot AI review requested due to automatic review settings May 7, 2025 11:28
@alessfg alessfg requested a review from a team as a code owner May 7, 2025 11:28
@alessfg alessfg self-assigned this May 7, 2025
@github-actions github-actions bot added the enhancement Enhance an existing feature label May 7, 2025
@alessfg alessfg added this to the 0.7.2 milestone May 7, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds templating support for the NGINX gzip static module by introducing a new "static" parameter setting in the relevant configuration files.

  • Added a "static" parameter to molecule converge configurations and the main template
  • Updated the CHANGELOG to reflect the new feature

Reviewed Changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.

File Description
molecule/complete_plus/converge.yml Added "static: false" to configuration for one test scenario
molecule/complete/converge.yml Added "static: always" to configuration for another test scenario
defaults/main/template.yml Updated template with "static: false" to support templating feature
CHANGELOG.md Logged the new templating support for the ngx_http_gzip_static_module
Files not reviewed (2)
  • templates/http/modules.j2: Language not supported
  • templates/stream/modules.j2: Language not supported
Comments suppressed due to low confidence (1)

molecule/complete/converge.yml:467

  • The 'static' parameter is set to 'always' here while other configurations and the template default to 'false'. Please confirm that this discrepancy is intentional and aligns with the expected behavior of the module.
static: always

@alessfg alessfg enabled auto-merge May 7, 2025 11:29
@alessfg alessfg changed the title feat: Template support for the NGINX gzip static module feat: Template support for the NGINX HTTP gzip static module May 7, 2025
@alessfg alessfg added this pull request to the merge queue May 8, 2025
Merged via the queue into main with commit ccf373a May 8, 2025
14 checks passed
@alessfg alessfg deleted the gzip-static branch May 8, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Variables for gzip_static
2 participants