Skip to content

Conversation

@pdabelf5
Copy link
Contributor

@pdabelf5 pdabelf5 commented Oct 22, 2025

Proposed changes

Allow users to optionally create the HorizontalPodAutoscaler with helm. This allows the use of Keda like systems.

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content.

@pdabelf5 pdabelf5 requested a review from a team as a code owner October 22, 2025 11:38
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nic Issues related to NGINX Ingress Controller labels Oct 22, 2025
@github-actions
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/1354/

Copy link
Member

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Please ensure the merge message adheres to our git conventions.

@pdabelf5 pdabelf5 changed the base branch from main to nic-release-5.3 October 22, 2025 12:27
@pdabelf5 pdabelf5 requested review from a team as code owners October 22, 2025 12:27
JTorreG and others added 19 commits October 22, 2025 13:29
workaround for an NGF callout render issue
* fix: Update nim-app-protect-support.md

* fix : Add NAP 5.9.0 version info to NIM

* Update content/nim/nginx-app-protect/setup-waf-config-management.md

* Update content/nim/nginx-app-protect/setup-waf-config-management.md

Co-authored-by: Jon Torre <[email protected]>

* Update content/nim/nginx-app-protect/setup-waf-config-management.md

Co-authored-by: Mike Jang <[email protected]>

* Update content/nim/nginx-app-protect/setup-waf-config-management.md

Co-authored-by: Jon Torre <[email protected]>

---------

Co-authored-by: Mike Jang <[email protected]>
Co-authored-by: Jon Torre <[email protected]>
fix: Update per WAF refactor
Added flowcarts for NGINX Plus license verification and usage reporting requirements. Simplified language in Getting Started guide.

---------

Co-authored-by: Mike Jang <[email protected]>
Co-authored-by: yar <[email protected]>
* Update linkchecker.yml

* Update linkchecker.yml

Add  https://my-deployment.my-region.nginxaas.net/connectivity to ignore list

* Update linkchecker.yml

---------

Co-authored-by: Jack Hickey <[email protected]>
various WAF typo fixes
* Update linkchecker.yml

Update with new waf endpoint name
* Add example to show users how to set NGINX_AGENT_LABELS

* Update content/nginx-one/agent/configure-instances/configuration-overview.md

Thank you!

Co-authored-by: Jon Torre <[email protected]>

---------

Co-authored-by: Jon Torre <[email protected]>
Removes restriction on the combination of both precompiled
and custom policies in an NGINX config.
* fix: remore NGINXaaS mention on N4A known issues
Update NGF release version 2.1.3
shaun-nx and others added 13 commits October 22, 2025 13:29
* Re add missing line for N1 Console telemetry

* fix: per @bjee19 request

---------

Co-authored-by: Alan Dooley <[email protected]>
Co-authored-by: Mike Jang <[email protected]>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.30.8 to 4.30.9.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@f443b60...16140ae)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.30.9
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 5 to 6.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v5...v6)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alan Dooley <[email protected]>
This commit adds the Response and Filetype feature pages to F5 WAF for
NGINX, and also updates other documentation to address feedback
regarding configuration or set-up problems.

---------

Co-authored-by: yar <[email protected]>
… docs (#1337)

This makes it clearer to users what kind of CNI configuration is applied to an AKS cluster built through the installation of the AKS extension.
…1341)

* docs: remove app_protect_enforcer_address from virtual-env waf doc
…cks (#1342)

remove extraneous underscores in the vicinity of inline code blocks

Co-authored-by: Alan Dooley <[email protected]>
…n group across 1 directory (#1338)

build(deps): bump playwright

Bumps the npm_and_yarn group with 1 update in the / directory: [playwright](https://github.com/microsoft/playwright).

Updates `playwright` from 1.48.0 to 1.56.1
- [Release notes](https://github.com/microsoft/playwright/releases)
- [Commits](microsoft/playwright@v1.48.0...v1.56.1)

---
updated-dependencies:
- dependency-name: playwright
  dependency-version: 1.56.1
  dependency-type: indirect
  dependency-group: npm_and_yarn
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alan Dooley <[email protected]>
@pdabelf5 pdabelf5 force-pushed the feat/nic-helm-hpa-create branch from bf61d9d to 9bfbe16 Compare October 22, 2025 12:30
@github-actions
Copy link

github-actions bot commented Oct 22, 2025

🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA), which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA and reply on a new comment with the following text to agree:


I have hereby read the F5 CLA and agree to its terms


31 out of 32 committers have signed the CLA.
✅ (JTorreG)[https://github.com/JTorreG]
✅ (vvnginx)[https://github.com/vvnginx]
✅ (mjang)[https://github.com/mjang]
✅ (lamATnginx)[https://github.com/lamATnginx]
✅ (travisamartin)[https://github.com/travisamartin]
✅ (nginx-aoife)[https://github.com/nginx-aoife]
✅ (aknot242)[https://github.com/aknot242]
✅ (nginx-seanmoloney)[https://github.com/nginx-seanmoloney]
✅ (edarzins)[https://github.com/edarzins]
✅ (bjee19)[https://github.com/bjee19]
✅ (pdabelf5)[https://github.com/pdabelf5]
✅ (ADubhlaoich)[https://github.com/ADubhlaoich]
✅ (vrmare)[https://github.com/vrmare]
✅ (ChisomUma)[https://github.com/ChisomUma]
✅ (sylwang)[https://github.com/sylwang]
✅ (nginx-jack)[https://github.com/nginx-jack]
✅ (Naveen-Gopu-F5)[https://github.com/Naveen-Gopu-F5]
✅ (mmaheswaran-f5)[https://github.com/mmaheswaran-f5]
✅ (kafeelhasan)[https://github.com/kafeelhasan]
✅ (russokj)[https://github.com/russokj]
✅ (rishabh-f5)[https://github.com/rishabh-f5]
✅ (y82)[https://github.com/y82]
✅ (vepatel)[https://github.com/vepatel]
✅ (cjain-f5)[https://github.com/cjain-f5]
✅ (dhurley)[https://github.com/dhurley]
✅ (AlexFenlon)[https://github.com/AlexFenlon]
✅ (valyria257)[https://github.com/valyria257]
✅ (puneetsarna)[https://github.com/puneetsarna]
✅ (jayaparthasarathyf5)[https://github.com/jayaparthasarathyf5]
✅ (shaun-nx)[https://github.com/shaun-nx]
✅ (arussellf5)[https://github.com/arussellf5]
@mattdesmarais
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@github-actions github-actions bot added product/nim Issues related to NGINX Instance Manager product/nginx-plus Issues related to NGINX Plus (and NGINX Open Source in docs.nginx.com) product/ngf Issues related to NGINX Gateway Fabric product/nginx-one Issues related to NGINX One Console product/nginxaas-azure Issues related to NGINX as a Service for Azure product/agent Issues related to NGINX Agent product/unit NGINX Unit tooling Back end, repository, Hugo, and all things not related to content process documentation Documentation related to how the repository or documention itself is managed. product/amplify Issues related to NGINX Amplify (EOS product) product/controller Issues related to NGINX Controller (EOS product) product/nms Issues related to NGINX Management Suite (EOS product) product/nap-waf labels Oct 22, 2025
@pdabelf5 pdabelf5 closed this Oct 22, 2025
@pdabelf5 pdabelf5 deleted the feat/nic-helm-hpa-create branch October 22, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation process documentation Documentation related to how the repository or documention itself is managed. product/agent Issues related to NGINX Agent product/amplify Issues related to NGINX Amplify (EOS product) product/controller Issues related to NGINX Controller (EOS product) product/ngf Issues related to NGINX Gateway Fabric product/nginx-one Issues related to NGINX One Console product/nginx-plus Issues related to NGINX Plus (and NGINX Open Source in docs.nginx.com) product/nginxaas-azure Issues related to NGINX as a Service for Azure product/nic Issues related to NGINX Ingress Controller product/nim Issues related to NGINX Instance Manager product/nms Issues related to NGINX Management Suite (EOS product) product/unit NGINX Unit tooling Back end, repository, Hugo, and all things not related to content

Projects

None yet

Development

Successfully merging this pull request may close these issues.