Skip to content

Conversation

haywoodsh
Copy link
Contributor

@haywoodsh haywoodsh commented Apr 14, 2025

Proposed changes

Add otel support for NGINX Ingress Controller OSS and Plus
Added config map keys:

  otel-exporter-endpoint: "[(http|https)://]host:port" # Required
  otel-exporter-header-name: "name" # Optional
  otel-exporter-header-value: "value" # Optional
  otel-service-name: "unknown_service:nginx" # Optional
  otel-trace-in-http: "false" # Optional, enables otel tracing at the http context

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added enhancement Pull requests for new features/feature enhancements go Pull requests that update Go code docker Pull requests that update Docker code labels Apr 14, 2025
@haywoodsh haywoodsh linked an issue Apr 23, 2025 that may be closed by this pull request
7 tasks
@pdabelf5 pdabelf5 force-pushed the feat/add-otel-support branch from 3f111b2 to 8c598c6 Compare April 29, 2025 16:47
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.47%. Comparing base (2f0cb58) to head (22359ed).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7642      +/-   ##
==========================================
+ Coverage   52.29%   52.47%   +0.18%     
==========================================
  Files          90       90              
  Lines       21472    21549      +77     
==========================================
+ Hits        11228    11308      +80     
+ Misses       9774     9772       -2     
+ Partials      470      469       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added the chore Pull requests for routine tasks label Apr 30, 2025
@haywoodsh haywoodsh force-pushed the feat/add-otel-support branch from 22e590f to 4cf0f62 Compare May 2, 2025 15:05
@github-actions github-actions bot removed the chore Pull requests for routine tasks label May 2, 2025
@haywoodsh haywoodsh force-pushed the feat/add-otel-support branch from 25f53b4 to bee7750 Compare May 6, 2025 15:27
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label May 6, 2025
@haywoodsh haywoodsh force-pushed the feat/add-otel-support branch from 8ad0ac7 to bee7750 Compare May 6, 2025 16:32
@github-actions github-actions bot removed the documentation Pull requests/issues for documentation label May 6, 2025
Copy link
Contributor

github-actions bot commented May 6, 2025

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/7642/

@github-actions github-actions bot added documentation Pull requests/issues for documentation dependencies Pull requests that update a dependency file python Pull requests that update Python code github_actions Pull requests that update Github_actions code helm_chart Pull requests that update the Helm Chart labels May 15, 2025
@haywoodsh haywoodsh force-pushed the feat/add-otel-support branch from 01535d0 to 1d581b5 Compare May 15, 2025 15:15
@github-actions github-actions bot removed documentation Pull requests/issues for documentation dependencies Pull requests that update a dependency file python Pull requests that update Python code github_actions Pull requests that update Github_actions code helm_chart Pull requests that update the Helm Chart labels May 15, 2025
@haywoodsh haywoodsh force-pushed the feat/add-otel-support branch from 714a273 to 406b1b8 Compare May 16, 2025 08:51
@github-actions github-actions bot added python Pull requests that update Python code tests Pull requests that update tests github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels May 16, 2025
@pdabelf5 pdabelf5 force-pushed the feat/add-otel-support branch from 2aade5c to 93b48df Compare May 22, 2025 10:53
@github-actions github-actions bot added chore Pull requests for routine tasks tests Pull requests that update tests and removed dependencies Pull requests that update a dependency file helm_chart Pull requests that update the Helm Chart labels May 22, 2025
AlexFenlon
AlexFenlon previously approved these changes May 22, 2025
@pdabelf5 pdabelf5 requested a review from AlexFenlon May 29, 2025 11:18
@pdabelf5 pdabelf5 merged commit 07c302f into main May 29, 2025
33 checks passed
@pdabelf5 pdabelf5 deleted the feat/add-otel-support branch May 29, 2025 15:20
@AlexFenlon AlexFenlon removed documentation Pull requests/issues for documentation go Pull requests that update Go code python Pull requests that update Python code github_actions Pull requests that update Github_actions code docker Pull requests that update Docker code chore Pull requests for routine tasks tests Pull requests that update tests labels Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement basic support for Otel
5 participants