Skip to content

Conversation

@rainerhahnekamp
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

A lot of noise in the CI logs

Closes #4998

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@netlify
Copy link

netlify bot commented Nov 16, 2025

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit 94d3a09
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-io/deploys/69198d8ca0453700080344a9

@netlify
Copy link

netlify bot commented Nov 16, 2025

Deploy Preview for ngrx-site-v19 ready!

Name Link
🔨 Latest commit 94d3a09
🔍 Latest deploy log https://app.netlify.com/projects/ngrx-site-v19/deploys/69198d8c1b115000089e2813
😎 Deploy Preview https://deploy-preview-4999--ngrx-site-v19.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rainerhahnekamp rainerhahnekamp marked this pull request as ready for review November 16, 2025 08:39
Copy link
Member

@markostanimirovic markostanimirovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run tests locally and you'll notice that some warnings are still present:

Screenshot 2025-11-16 at 13 07 28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@ngrx/signals: Reduce console.warn noise in signals tests

3 participants