MSVC symbol decorators #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit c010d02 adds the equivalent
__attribute__((noreturn))function decorator in MSVC.commit a4367b1 is more involved, adding MSVC function decorators to support importing and exporting symbols. By default in shared libraries when built using MSVC, no symbols are exported, and symbols must be explicitly marked
__declspec(dllexport). Additionally, global variables must be explicitly imported using__declspec(dllimport)placed immediately after anexternbefore the variable type (functions are implicitly imported). This is required to link logtools built using MSVC on Windows as a shared object (DLL). Should not affect building using GCC/CLANG as it's#ifdef-gated behind_MSC_VER. Would like someone to review this one if possible?