Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed BG color to green. #154

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

stagg54
Copy link
Contributor

@stagg54 stagg54 commented Mar 10, 2025

GitHub Issue for the Pull Request

Link to the relevant GitHub issue

GitHub Discussions Related to this Pull Request

List any GitHub discussion links related to this PR

Checklists

Completing these checklists ensures that your PR meets our build server requirements on the first attempt. If you're unable to complete any of the following checks, please submit your PR as a draft to the best of your ability. We will provide any clarification you may need after posting it.

  • I do not require assistance from NI to complete any of the following checks.
  • The changes in this PR are based on the appropriate NI-repo feature branch
  • I am submitting the changes in this PR to the appropriate NI-repo feature branch
  • I built a VI Package using the Powershell build tool.
  • I installed the VI Package produced by the Powershell build tool and tested my change.
  • I tested my changes after installing the VI package.
  • NI has my contributor license agreement.

Summary of Changes

Provide a concise overview of what is being added, modified, or fixed in this pull request. Make an emphasis on what was not captured on the GitHub issue, or discussion associated with this PR.

Reason for Change

Explain the problem or need addressed by this pull request, including any relevant background information.

Visual Aids

Include any visual aids that would help the reviewer gain additional context.

Additional Information

Include any further details that may assist the reviewer in understanding the context of this PR.

Testing

This section describes the automated and manual tests performed for this bugfix/feature.

Manual Tests

Describe any manual tests conducted.

@svelderrainruiz svelderrainruiz self-requested a review March 10, 2025 20:55
@svelderrainruiz svelderrainruiz enabled auto-merge (squash) March 10, 2025 20:56
@svelderrainruiz svelderrainruiz merged commit b11c75b into ni:feature/sam-test-pr Mar 10, 2025
1 check passed
svelderrainruiz added a commit that referenced this pull request Mar 13, 2025
* Changed BG color to green. (#154)

* Bumped VIPB version

* Adding initial revision

* Adding what was installed

* Revert "Adding what was installed"

This reverts commit 2ccc793.

* Deleted all tooling

* test

* Added extension

* Extension can be seen but there is an error

* Extension is capable of building

* Added real time output capabilities

* Script accepts semantinc versioning

* Adding extension to build VI Packages

* Accepts a file path with the release notes as an argument. If path does not exist, it creates it.

* Correct parameter is now passing the version to the VI Package

* If an error occurs, the script is now responsible for closing its own labview execution.

* Baseline using a try catch block

* Always try to apply dependencies twice to take into account the first failed execution when there is a very big initial VIPC

* Checks if VIPC needs applying before applying it

* Removed technical debt

* Removed deprecated script. will need to update github action

* baseline with error

* fixed example to use build 1 and not 0

* progress

* One of the copy VIs was not set to overwrite

* Updated only to bare minimum dependencies for the runner

* Revert "Updated only to bare minimum dependencies for the runner"

This reverts commit f413f9b.

* added runner dependencies

* Updated dependencies

* bringing back change

* Excluding new files

* Was missing a destination override for the ppls

* Changes to actions

* Added LoadGraphics.vi as a dependency

* Handles labview minor versions. This breaks all callers of this script.

* Now accepts updated prototype

* Enabled error

* added an exclution to not include releasenotes.md.

* Added the backup for the icon editor 2025 64 bits

* cancels multiple workflows

* test

* Update my-heavy-workflow.yml

Signed-off-by: sergiov-ni <[email protected]>

* Update my-heavy-workflow.yml

Signed-off-by: sergiov-ni <[email protected]>

* Update my-heavy-workflow.yml

Signed-off-by: sergiov-ni <[email protected]>

* adding correct yaml file

* Update and rename my-heavy-workflow.yml to cancel-previous.yml

Signed-off-by: sergiov-ni <[email protected]>

* Update cancel-previous.yml

Signed-off-by: sergiov-ni <[email protected]>

* Update cancel-previous.yml

Signed-off-by: sergiov-ni <[email protected]>

* Delete .github/workflows/cancel-previous.yml

Signed-off-by: sergiov-ni <[email protected]>

---------

Signed-off-by: sergiov-ni <[email protected]>
Co-authored-by: Samuel Taggart <[email protected]>
Co-authored-by: Sergio Velderrain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants