examples: Use session-based simulation by default #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brad Keryan <[email protected]>
Signed-off-by: Brad Keryan <[email protected]>
bkeryan
requested review from
csjall,
pbirkhol-ni,
dixonjoel,
nstokes-nati and
mshafer-NI
as code owners
bkeryan
commented
May 2, 2023
bkeryan
commented
May 2, 2023
bkeryan
commented
May 2, 2023
Signed-off-by: Brad Keryan <[email protected]>
Signed-off-by: Brad Keryan <[email protected]>
|
So with this setup, is it true that the user doesn't have to do anything in NI-MAX? Or do you still need to add a simulated device in NI-MAX? |
Yes, you no longer have to add simulated devices in NI MAX. If you do add a simulated device in NI MAX, you have to set USE_SIMULATION=False in order to use it. |
dixonjoel
approved these changes
May 2, 2023
bkeryan
commented
May 2, 2023
Signed-off-by: Brad Keryan <[email protected]>
1 task
When you initialize a dict with `d = {}`, mypy infers the key/value types from the
first usage. To allow heterogenous values, add a type annotation.
Signed-off-by: Brad Keryan <[email protected]>
Signed-off-by: Brad Keryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Update examples for modular instruments to use session-based simulation by default.
Why should this Pull Request be merged?
Make examples run "out of the box".
Enable simulation for instruments that either do not support persistent simulation in NI MAX or require TSM offline mode to enable persistent simulation.
What testing has been done?
Manually tested all examples in InstrumentStudio and TestStand.