Fix verification errors caused by 'contains' function #61
+54
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a contains_exact function to address uncaught errors in verifications caused by only checking for substrings in the contains function. - Reviewed and updated all instances of the contains function in the nilrt-snac package to ensure proper usage. Signed-off-by: Eli Engelhardt <[email protected]>
eli-engelhardt
requested review from
amstewart,
AlexHearnNI and
a team
as code owners
Signed-off-by: Eli Engelhardt <[email protected]>
dmondrik
reviewed
Mar 10, 2025
| @@ -15,6 +15,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| * Restricted write access to system logs in `/var/log` to System Maintainers (root) and Auditors via the `adm` group. | |||
| * Restricted write access to `auditd.conf` to System Maintainers and Admins via the `sudo` group. | |||
|
|
|||
| ### Fixed | |||
| * Corrected the `verify` operation to ensure it accurately detects configuration changes. | |||
There was a problem hiding this comment.
The bug also says that running nilrt-snac configure -y did not fix the problem. Does your change address that?
There was a problem hiding this comment.
It does in my latest commit
Signed-off-by: Eli Engelhardt <[email protected]>
amstewart
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Justification
As stated in the bug, the 'contains' function in
_config_file.pyonly checks for substring which would allow for improper verification. For example, the nilrt-snac configuration puts in the following entry: ClientAliveCountMax 4However if the user changes it,
nilrt-snac verifywouldn't throw an error for something like this: ClientAliveCountMax 40, which is not the behavior we want.Testing
Tested whether exact and non-exact string matches have acceptable behaviors for each modified configuration file.
Procedure