Open
Conversation
sc0Vu
reviewed
Mar 23, 2024
sc0Vu
left a comment
There was a problem hiding this comment.
@Seldaek is php also vulnerable to early return?
Here is my test script, how do you think?
#!/usr/bin/env php
<?php
$balance= 100;
function substractBalance($amount) {
/* Subtract funds from bank account then /*/ return ;
$balance -= $amount;
}
echo "Starting Balance: " . $balance . PHP_EOL;
substractBalance(50);
echo "After Subtracting 50: " . $balance . PHP_EOL;
Author
|
I guessI'd mark it as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based off the JS tests as the languages are very similar. This has also been reported as a security issue to the PHP project (security reports are private so I can't link to it).