Skip to content

fix: prevent Orca interviews canceling during tab creation - #26

Open
w-winter wants to merge 1 commit into
nicobailon:mainfrom
w-winter:fix/orca-tabs
Open

w-winter wants to merge 1 commit into
nicobailon:mainfrom
w-winter:fix/orca-tabs

Conversation

@w-winter

Copy link
Copy Markdown
Contributor

This fixes Orca interviews sometimes canceling immediately and returning preselected recommendations as partial user responses. Orca can reload the initial URL during tab creation, triggering the form's pagehide cancellation before the user has a chance to answer.

Summary

  • Create and focus an about:blank tab, then navigate to the interview URL by page ID
  • Add regression coverage for the launch sequence and navigation errors

Validation

Passed:

  • npm test (180 tests)
  • npm run typecheck
  • Real Orca e2e testing: manual submission with no other tabs open, five automated blocking calls and two async calls with another tab open; all returned the submitted answers

The original launcher reproduced the bug under the same conditions, cancelling an untouched form after 277 ms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant