fix: animate spinner in foreground and async subagent widgets#237
Closed
NOirBRight wants to merge 1 commit into
Closed
fix: animate spinner in foreground and async subagent widgets#237NOirBRight wants to merge 1 commit into
NOirBRight wants to merge 1 commit into
Conversation
- runningGlyph now incorporates real time (Date.now() / 120) so it rotates even when status data hasn't changed during long LLM waits - buildWidgetComponent returns a dynamic render component instead of a static Container+Text tree, allowing glyph to refresh on each TUI frame - add widgetAnimationTimer to drive periodic requestRender for async widget - add foreground result animation timer with dispose cleanup on component removal - add invalidate() to widget component for pi-tui contract compliance - guard widgetAnimationTimer callback with hasUI check
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Author
|
Closing in favor of #244, which carries the spinner animation fix together with the session-scoped temp directory changes currently needed by the fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The spinner (running glyph) in both foreground subagent results and async widget frequently freezes during long-running subagent tasks — especially when the child agent is waiting for LLM responses with no status file updates.
Root Cause
Changes
Verification