Make the default binary statically linked. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default binary was dynamically linked (*dynamic* target instead of *release* target), but this meant that the default binary failed to run if LD_LIBRARY_PATH was not set, when PREFIX was set to a non-default value. In other words, installing minisat into your home dir resulted in a binary that would not run out of the box. The problem is that the dynamically linked minisat binary depends on libminisat. I ran into this while trying to install tip from source: it needed a newer version of minisat than my package manager provided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default binary was dynamically linked (dynamic target instead of
release target), but this meant that the default binary failed to
run if LD_LIBRARY_PATH was not set, when PREFIX was set to a
non-default value. In other words, installing minisat into your home
dir resulted in a binary that would not run out of the box. The
problem is that the dynamically linked minisat binary depends on
libminisat.
I ran into this while trying to install tip from source: it needed a
newer version of minisat than my package manager provided.