Specify default argument in the declaration not the friend declaration #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Much nicer. I have no idea why I was doing what I was doing. Must have been late at night 🌚 . |
|
Is this still alive?? 💀 |
…ace between literal and string macro [-Wliteral-suffix]
fixed GCC 6.3 warning: invalid suffix on literal; C++11 requires a sp…
RPath needed by MacOSX was not correctly set for minisat. Therefore it was not correctly linked against STP.
Fix linking of minisat as dependency library on MacOSX
Quell some clang warnings
Adding Export, fixing static libraries and binaries
On 64bit systems, the usual destination for libraries is /usr/lib64, not /usr/lib. So add CMAKE_INSTALL_LIBDIR and allow overriding the the default.
This reverts commit 1193f18.
frogeyedpeas
approved these changes
Oct 12, 2022
|
can this be merged in? i'm getting issues due to the friend declaration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #22