Fix compilation errors #36
Open
+13
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 7, 2019 14:05
CLang reports this error:
./minisat/core/SolverTypes.h:55:16: error: friend declaration specifying a default argument must be a definition
friend Lit mkLit(Var var, bool sign = false);
^
./minisat/core/SolverTypes.h:63:14: error: friend declaration specifying a default argument must be the only declaration
inline Lit mkLit (Var var, bool sign) { Lit p; p.x = var + var + (int)sign; return p; }
^
./minisat/core/SolverTypes.h:55:16: note: previous declaration is here
friend Lit mkLit(Var var, bool sign = false);
^
2 errors generated.
CLang reports this error:
minisat/utils/System.cc:90:17: error: out-of-line definition of 'memUsedPeak' does not match any declaration in namespace 'Minisat'
double Minisat::memUsedPeak() { return memUsed(); }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes two compilation errounds found when compiling minisat under Mac OS (clang).
There are still bugs when generating the libraries, as the
--staticand-sonameflags are not recognized. I fixed them adhoc in theMakefile, but I guess these should be fixed in theCMakeLists.txtfile