Moving schedule to a global setting#38
Open
brammh wants to merge 1 commit into
Open
Conversation
Moving the calendar/schedule to a global setting, Such it can be re-used cross filter and normal nodes. Also avoid lot's up duplicate code between 'light-scheduler' and 'light-scheduler-filter'
Owner
|
Thank you for the contribution! I have not had a chance to look at the changes yet, but will do so soon and get back to you. /Niklas Wall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving the calendar/schedule to a global setting, such the same schedule configuration can be re-used cross the filter and normal node(s). It reduces duplicate code between 'light-scheduler' and 'light-scheduler-filter'.