Skip to content

fixes #24760; Noncopyable base type ignored #24777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 22, 2025
Merged

fixes #24760; Noncopyable base type ignored #24777

merged 8 commits into from
Sep 22, 2025

Conversation

ringabout
Copy link
Member

fixes #24760

I tried incl tfHasAsgn to nontrivial assignment, but that solution seems to break too many things. Instead, in this PR, passCopyToSink now checks nontrivial assignment

@ringabout ringabout marked this pull request as draft March 14, 2025 11:19
@ringabout ringabout marked this pull request as ready for review September 19, 2025 14:57
@Araq Araq merged commit e958f4a into devel Sep 22, 2025
21 checks passed
@Araq Araq deleted the pr_fix_ddc branch September 22, 2025 08:51
@github-actions GitHub Actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from e958f4a

Hint: mm: orc; opt: speed; options: -d:release
183068 lines; 8.302s; 660.262MiB peakmem

narimiran pushed a commit that referenced this pull request Sep 24, 2025
@ringabout @narimiran
fixes #24760; Noncopyable base type ignored (#24777)
5724c68 
fixes #24760

I tried `incl` `tfHasAsgn` to nontrivial assignment, but that solution
seems to break too many things. Instead, in this PR, `passCopyToSink`
now checks nontrivial assignment

(cherry picked from commit e958f4a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Noncopyable base type ignored
2 participants
@ringabout @Araq