Implement async download based on chronos #1023
Open
+399
−173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yyoncho
commented
Aug 24, 2022
yyoncho
commented
- implementation of async download based on chronos asyncproc
- the PR is based on Asynchronous dowloads of dependencies. #938
yyoncho
force-pushed
the
async
branch
3 times, most recently
from
ddc62e3 to
16c4678
Compare
- implementation of async download based on chronos asyncproc - the PR is based on nim-lang#938
|
Nimble is shipped with the Nim compiler and should not depend on external libraries. Also it caches dependencies permanently, and most dependencies are pretty small. It's difficult to justify the additional complexity of parallel download. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.