Expand forge aliases when requirement is parsed #1385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s either a URL or a package) Means we aren't having to expand it all over the place
Not needed anymore
Make the test look like other tests
Since it doesn't exist locally I can't use the vcs check function. I don't need it all anyways so easier to copy a minimal version once than to add another random flag parameter
xTrayambak
approved these changes
Apr 25, 2025
Issue was it was checking the binary exists without adding the binary extension
|
Don't know why the CI isn't running again, but passed in my repo |
Not sure why CI didnt get triggered. Try closing it and reopen |
Age old trick of turning it off and on again works =P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1341
This moves the expansion step to when the requirement is parsed (meaning a
PkgTuplenow again only refers to a URL or a package). This removes the need to have special handling for the SAT solver/lock files.