Skip to content

Conversation

@MorganaFuture
Copy link

  • Add extractPackageName() to extract package names from URL
  • Update warning messages to show specific package name
  • Add unit tests for new functionality

Link: Issues 1432

@jmgomez
Copy link
Collaborator

jmgomez commented Aug 12, 2025

This approach is quite fragile i.e. https://github.com/status-im/nim-json-serialization/

@arnetheduck
Copy link

If the canonical name is not available yet, I think it's fine to print the url / whatever was given to requires in this case

@jmgomez
Copy link
Collaborator

jmgomez commented Aug 12, 2025

The name is available though as the package is supposed to be cloned already

Edit: you are right. Looked at a bad spot in the code. The right thing to do is to print the url

@MorganaFuture MorganaFuture force-pushed the MorganaFuture/feat/add_package_name_in_warning branch from 6afa2aa to 4b8626a Compare August 26, 2025 07:23
@MorganaFuture
Copy link
Author

Hi @jmgomez @arnetheduck I rewrote the PR to show the URL instead of the name. I also used nph for formatting, as I understand it, it is not mandatory in the project?) Is it necessary to revert everything back?

@Araq
Copy link
Member

Araq commented Aug 26, 2025

Is it necessary to revert everything back?

IMHO, yes, as now the diff contains many random changes and worse, the original formatting seems better too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants