fix: preserve custom snapshot metadata after compaction#131
Merged
Conversation
Summary Custom/non-standard snapshot metadata properties (e.g. pipeline-id, bobsled.source-table) were silently dropped after compaction Read previous snapshot's non-standard properties and pass them through via set_snapshot_properties() on both RewriteFilesAction and OverwriteFilesAction Standard Iceberg summary keys (total-records, added-data-files, etc.) are still correctly recalculated by iceberg-rust — only custom keys are preserved Changes Added custom_snapshot_properties() helper and KNOWN_SNAPSHOT_SUMMARY_KEYS constant Modified CommitManager::rewrite_files() and CommitManager::overwrite_files() to inject custom properties Added end-to-end test and unit test for the filtering logic
Summary Custom/non-standard snapshot metadata properties (e.g. pipeline-id, bobsled.source-table) were silently dropped after compaction Read previous snapshot's non-standard properties and pass them through via set_snapshot_properties() on both RewriteFilesAction and OverwriteFilesAction Standard Iceberg summary keys (total-records, added-data-files, etc.) are still correctly recalculated by iceberg-rust — only custom keys are preserved Changes Added custom_snapshot_properties() helper and KNOWN_SNAPSHOT_SUMMARY_KEYS constant Modified CommitManager::rewrite_files() and CommitManager::overwrite_files() to inject custom properties Added end-to-end test and unit test for the filtering logic
vovacf201
requested review from
Li0k,
chenzl25,
jonathanc-n,
mwylde and
nagraham
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Custom/non-standard snapshot metadata properties (e.g. pipeline-id) were silently dropped after compaction Read previous snapshot's non-standard properties and pass them through via set_snapshot_properties() on both RewriteFilesAction and OverwriteFilesAction Standard Iceberg summary keys (total-records, added-data-files, etc.) are still correctly recalculated by iceberg-rust — only custom keys are preserved
Changes
Before
After
