Skip to content

Conversation

@tsalo
Copy link
Collaborator

@tsalo tsalo commented Nov 24, 2025

Replaces #3569. Relates to #3364. This acts as a short-term patch until we figure out how best to process two-echo fMRI data.

Changes proposed in this pull request

  • If two-echo fMRI data are provided and --echo-idx is not, raise a RuntimeError.

Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@effigies effigies force-pushed the error-on-two-echo-2 branch from 3457563 to d6d0353 Compare November 25, 2025 03:03
@effigies effigies force-pushed the error-on-two-echo-2 branch from d6d0353 to 1ea45f4 Compare November 25, 2025 03:45
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.88%. Comparing base (e3c6dfd) to head (1ea45f4).
⚠️ Report is 2 commits behind head on maint/25.2.x.

Files with missing lines Patch % Lines
fmriprep/workflows/base.py 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           maint/25.2.x    #3570      +/-   ##
================================================
- Coverage         72.92%   72.88%   -0.05%     
================================================
  Files                60       60              
  Lines              4817     4820       +3     
  Branches            625      626       +1     
================================================
  Hits               3513     3513              
- Misses             1162     1164       +2     
- Partials            142      143       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@effigies effigies merged commit 7273193 into nipreps:maint/25.2.x Nov 25, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants