Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of PAT (Personal Access Token) token #16

Merged
merged 5 commits into from
Jan 16, 2025
Merged

Conversation

jigar-joshi-nirmata
Copy link
Contributor

@jigar-joshi-nirmata jigar-joshi-nirmata commented Dec 22, 2024

I was working on removal of PAT, and while finding the use of PAT across nirmata, I came to this codebase.
I tried to

  1. Remove the PAT token
  2. Replace the PAT token with Github Token

Both the flow worked,
but because this workflow worked without token, I am suggesting the change to remove the token.

Please refer to confirm the working flow:
https://github.com/nirmata/action-install-nctl-scan/actions/runs/12451838303

@jigar-joshi-nirmata jigar-joshi-nirmata added the enhancement New feature or request label Dec 22, 2024
@jigar-joshi-nirmata jigar-joshi-nirmata self-assigned this Dec 22, 2024
@amittiwari28
Copy link
Contributor

If token is removed, how would you get polices from a private repo?

@anusha94 anusha94 merged commit 72369d7 into main Jan 16, 2025
1 check passed
@anusha94 anusha94 deleted the token-removal-flow branch January 16, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants