Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart improvements #127

Merged
merged 1 commit into from
Jan 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,5 @@ notation-com.amazonaws.signer.notation.plugin_linux_amd64

.DS_Store
.tools
coverage.txt
coverage.txt
/.idea/
14 changes: 13 additions & 1 deletion charts/kyverno-notation-aws/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ spec:
runAsNonRoot: true
serviceAccountName: {{ template "kyverno-notation-aws.serviceAccountName" . }}
containers:
- image: ghcr.io/nirmata/kyverno-notation-aws:latest
- image: "{{ .Values.image.repository }}:{{ .Values.image.tag }}"
imagePullPolicy: Always
name: kyverno-notation-aws
args:
Expand Down Expand Up @@ -74,6 +74,18 @@ spec:
volumeMounts:
- name: notation
mountPath: /notation
{{- with .Values.nodeSelector }}
nodeSelector:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with .Values.affinity }}
affinity:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with .Values.tolerations }}
tolerations:
{{- toYaml . | nindent 8 }}
{{- end }}
volumes:
- name: notation
emptyDir: {}
20 changes: 18 additions & 2 deletions charts/kyverno-notation-aws/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ fullnameOverride: ~
# -- (string) Override the namespace the chart deploys to
namespaceOverride: ~

image:
repository: ghcr.io/nirmata/kyverno-notation-aws
tag: c6d5d94e638e36bd9c29ff0a78fbfa64b555d561

# CRDs configuration
crds:

Expand Down Expand Up @@ -50,5 +54,17 @@ serviceAccount:
# Config map configuration
configMap:

# -- The configmap name
name:
# -- The notation-plugin-config configmap name
name: notation-plugin-config

# nodeSelector for extension Deployment. More details:
# https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#nodeselector
nodeSelector: {}

# tolerations for extension Deployment. More details:
# https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/
tolerations: []

# affinity for extension Deployment. More details:
# https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#affinity-and-anti-affinity
affinity: {}