NDEV-20544: add remediate policies for RBAC best practices #169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds remediation policies for the following RBAC best practices policies:
In
remediate-restrict-clusterrole-nodesproxy
policy, we are replacingnodes/proxy
with""
instead of removing it.Consider we have a
ClusterRole
like this where theresources
array contains a single elementnodes/proxy
When we apply the remediate policy on this, it gets mutated to:
If we had performed a
remove
operation onnodes/proxy
, then creation of theClusterRole
would have been blocked by Kubernetes with the following error:The ClusterRole "badcr03" is invalid: rules[0].resources: Required value: resource rules must supply at least one resource
An empty string
""
does not match any resources and can be considered a dummy value.The above approach of replacing instead of removing has been followed in
remediate-restrict-wildcard-resources
policy tooRelated Issues:
Checklist: