Skip to content

For #307: Error chomp on nil #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

For #307: Error chomp on nil #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15efa9f
Fix error chomp on nil
Taknok Feb 17, 2022
4104e7e
set bin executable to suppress warning
Taknok Feb 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file modified bin/svn2git
100644 → 100755
View file
Open in desktop
Empty file.
10 changes: 9 additions & 1 deletion lib/svn2git/migration.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,15 @@ def run_command(cmd, exit_on_error=true, printout_output=false)
# for input and place any received values on a queue for consumption by a pass-through thread that will forward
# the contents to the underlying sub-process's stdin pipe.
@stdin_thread ||= Thread.new do
loop { @stdin_queue << $stdin.gets.chomp }
loop do
# gets may return nil, and nil cannot be chomped
input = $stdin.gets
if input.nil?
@stdin_queue << input
else
@stdin_queue << input.chomp
end
end
end

# Open4 forks, which JRuby doesn't support. But JRuby added a popen4-compatible method on the IO class,
Expand Down