test(core): add ReadResource response shaping assertions - #330
Open
yashmittal02 wants to merge 1 commit into
Open
test(core): add ReadResource response shaping assertions#330yashmittal02 wants to merge 1 commit into
yashmittal02 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds explicit tests for
ReadResourceresponse shaping based oncontent.type.The tests verify that:
textresources return their data using thetextfield.binaryresources return Base64-encoded data using theblobfield.jsonresources are stringified and returned using thetextfield.mimeTypeis preserved in each response.Closes #18
Type of Change
Testing
Ran the targeted core test suite:
npx jest src/core/__tests__/server.extended.test.tsResult:
The tests cover
text,binary, andjsonresource response shapes.Checklist