Repository navigation
chore(release): prepare 3.7.1 - #253
Merged
Merged
Conversation
Patch rather than minor: nothing is added. This plugin no longer switches itself off when Ghost Kit Pro is activated, and the two now stay activated side by side. The Pro half of the release fixes effects that could fail to start, leaving a reveal block hidden on the page. Translations are regenerated. The template had been left at 3.6.1, so it also picks up the strings 3.7.0 added. Ghost Kit Pro follows this release. Its `bump-from-core` takes the number from `core-plugin`, so it can only be numbered 3.7.1 once this is tagged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch rather than minor: nothing is added. Two lines for users. This plugin no longer switches
itself off when Ghost Kit Pro is activated, so the two stay activated side by side and this one
loads none of its own code while Pro is running. On the Pro side, effects could fail to start
when its bundle finished loading after the core one, which left a reveal block hidden on the
page for good and filled the console with errors.
Translations are regenerated. The template had been sitting at 3.6.1, so it also picks up the
strings 3.7.0 added.
assets/vendor/gist-simple/dist/gist-simple.min.jsis deliberately left as it is. The buildcopies that file out of
node_modules, which undoes the hand patch from167011fb, so it is kept out of this
release.
Ghost Kit Pro follows this release, not the other way round. Its
npm run bump-from-coretakes the number from
core-plugin, so it can only be numbered 3.7.1 once this is merged andtagged.
Verified in wp-env against Ghost Kit Pro, single site and multisite: Pro alone loads its bundled
core; both active in either include order leaves only this plugin's main file included, and it
returns; a copy below 3.7.1 is still deactivated; network-activated next to a site-activated Pro
it steps aside on that site and keeps running on the sites without Pro.
npm run lint,npm run test:unit:phpandphpcsare green.