Repository navigation
refactor(video): spell the showControls option correctly - #256
Merged
Merged
Conversation
VideoWorker got `showContols`, dropped it as unknown, and fell back to its own default for `showControls`. That default is `true` and the line passed `1`, so nothing a user sees changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Video block passed
showContolsto VideoWorker. The library never saw the option it wasmeant to receive, dropped the misspelled key as unknown, and used its own default for
showControls.Nothing a visitor sees changes. That default is
trueand the line passed1, so the playershowed its controls either way. Confirmed by building both spellings against video-worker
3.1.0 under jsdom, which produce the same embed URL, and by playing the block on a local site
after the rename.
The value in fixing it is that the line now does what it says, so a future change to the
library's default cannot silently flip the block's controls off.