Skip to content

Dev#11

Open
Veronicasenami1218 wants to merge 12 commits into
nkatha23:devfrom
Veronicasenami1218:dev
Open

Dev#11
Veronicasenami1218 wants to merge 12 commits into
nkatha23:devfrom
Veronicasenami1218:dev

Conversation

@Veronicasenami1218

Copy link
Copy Markdown

No description provided.

nkatha23 and others added 7 commits May 21, 2026 15:08
feat: add arklabs website link
Revert "feat: add arklabs website link"
This commit normalizes all website URLs by removing 'www.' to ensure consistency across the dataset. It also fills in the missing 'community' keys for ARK Labs, Bitcoin Core, LND, Nostr, P2Pool, Saving Satoshi, and Shopstr by linking to their official IRC channels, Slack workspaces, Telegram groups, or Discord servers.
Refactor: Standardize JSON URLs and add missing community links
Included Sparrow wallet links, website and github
Comment thread data/orgs.json Outdated
"github": "https://github.com/ArkLabsHQ",
"website": "https://arklabs.xyz/"

"community": ""

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the diff shows the arklabs website field is being removed and replaced with "community": "". Please restore the website field and either fill in a real community link or remove that field entirely, empty strings will fail validation.

@nkatha23

Copy link
Copy Markdown
Owner

Hey @Veronicasenami1218, thanks for contributing! A few things to fix before this can be merged:

  1. Add a PR description — let us know which orgs you added and why. "No description provided" makes it hard to review.

  2. Sync with the latest changes — your branch has picked up 3 of my commits that aren't yours. Please rebase onto the latest main:

git fetch upstream
git rebase upstream/main
git push --force-with-lease origin dev

This should leave only your commit in the PR.

  1. Typo in commit message — Added two more organizaqtions , while rebasing, clean this up to follow the convention: feat: add stratum-v2 and validating-lightning-signer

Happy to help if you get stuck:)

@Veronicasenami1218

Copy link
Copy Markdown
Author

Hey @Veronicasenami1218, thanks for contributing! A few things to fix before this can be merged:

  1. Add a PR description — let us know which orgs you added and why. "No description provided" makes it hard to review.
  2. Sync with the latest changes — your branch has picked up 3 of my commits that aren't yours. Please rebase onto the latest main:
git fetch upstream
git rebase upstream/main
git push --force-with-lease origin dev

This should leave only your commit in the PR.

  1. Typo in commit message — Added two more organizaqtions , while rebasing, clean this up to follow the convention: feat: add stratum-v2 and validating-lightning-signer

Happy to help if you get stuck:)

@Veronicasenami1218

Copy link
Copy Markdown
Author

Thanks for the feedback! Addressed all three:

  • Rebased onto latest upstream/main (only my commit remains).
  • Fixed the commit message to follow the convention.
  • Added a proper PR description.

@nkatha23 nkatha23 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're deleting ci.yml , the diff shows the entire CI workflow being removed. Please restore it, that file needs to stay. You may have accidentally deleted it while rebasing. Check with:

git status
git checkout upstream/main -- .github/workflows/ci.yml

@nkatha23

Copy link
Copy Markdown
Owner

Please squash your 12 commits into one , your PR has a mix of your commits and merge commits from the main repo that don't belong here. After restoring the CI file, squash everything down to a single clean commit:

git rebase -i HEAD~12

Mark the first as pick, change all others to squash, then write one clean message e.g. feat: add stratum-v2 and validating-lightning-signer. Then:

git push --force-with-lease origin dev

Also restore the arklabs website field, "website": "https://arklabs.xyz" — it's being replaced with a community link in your diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants