-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for latin encondig according to Brazilian Digital Television System (SBTVD / ISDB-Tb). #16
base: master
Are you sure you want to change the base?
Conversation
…f Brazilian Digital Television System (SBTVD / ISDB-Tb).
Adjust tables names.
Latin already means something else compared to ASCII. |
"Latin" is the term employed by the standard. Not sure if it is the best one, but I'd be ok to use another word. |
Hi, Cartegnie. Do you want me to change something? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, Cartegnie. Do you want me to change something?
there's already remarks around here
@@ -66,6 +66,8 @@ typedef struct arib_instance_t | |||
bool b_generate_drcs; | |||
bool b_use_private_conv; | |||
bool b_replace_ellipsis; | |||
bool is_latin; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use enum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I use enum for japanese and brazilian standards?
} | ||
} | ||
|
||
void arib_initialize_decoder_latin( arib_decoder_t* decoder ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add generic api with encoding parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for asking, but I did not catch what you mean by "generic api".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We won't add a new init api for each decoder. init( &dec, ARIB_B25 ) init( &dec, SBTVD )
以下の議論を参考にした: [Add support for latin encondig according to Brazilian ~ by andrelcm]( nkoriyama/aribb24#16 )
Dear maintainers,
This pull request supports latin enconding for Brazilian Digital Television System (SBTVD / ISDB-Tb) accorind to official standard ABNT 15606-1 (2013), related to issue #8.
This document is portuguese, so I will try to translate the relevant parts.
Table 16 specififies the following desginations:
Thus, I created a initialization for latin decoder with following code:
decoder->handle_g0 = decoder_handle_alnum_latin;
decoder->handle_g1 = decoder_handle_alnum_latin;
decoder->handle_g2 = decoder_handle_latin_extension;
decoder->handle_g3 = decoder_handle_latin_special;
Since there is no technique specified to change to these designations, I included a code in 'parse_caption_management_data' to detect the language. If it is portuguese or spanish (this standard is also used in Argentina), an attribute in the instance is set to define the use of latin initialization.
I tested the code with VLC and the files suplied in #15. It seems that the japanese portion is not broken, but I am not sure since I don't know japanese. If you want, you can also test with a dump I made from a brazilian broadcast: test.ts.
Regards,
André Moreira