Skip to content

Conversation

@xperiandri
Copy link

No description provided.

@nkovacic
Copy link
Owner

Will look into it.

@xperiandri
Copy link
Author

In SDK 11 they return a response from which you can get IAsyncEnumerable or pages of IAsyncEnumerable.
I don't know how to implement that yet to return from IQueryable.

And it would be nice to pass Expression<Func<T,T>> to some extension method on SearchClient which would just add filtering logic without changing the shape of data.

@nkovacic
Copy link
Owner

I am currently setting up CI also for Pull Requests. Tests also do not build anymore, could this be also fixed?

@xperiandri
Copy link
Author

Yes, I've just haven't looked into tests because I wanted your response on my implementation

@nkovacic
Copy link
Owner

SearchClientExtensions is a great addition, much better than the current implementation. I did not have much time to maintain this package but will try to assist with this WIP.

@xperiandri
Copy link
Author

The main issue for me is that I'm not experience enough in working with Expression.
I was trying to achieve 2 points:

  1. Ability to pass a lambda and translate it to a query
  2. Preserve your implementation that can execute Expressions but adjust it to a modern IAsyncEnumerable if possible

@nkovacic
Copy link
Owner

Integration tests covered almost all possible cases for Expressions. When they build and run, that should indicate if everything works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants