Improvements: legacy bucket names, open-ended byte-range requests (samtools/tabix), removed need to hard-code bucket names. - #2
Open
obenshaindw wants to merge 4 commits into
Conversation
Changed s3 connection to use boto OridnaryCallingFormat library.
Supports mixed case bucket names now, doesn't require bucket name to be specified in YAML config (i.e., can use full s3 URL to any bucket the keys have access to), supports range requests with no end-range (enables use of tabix and samtools with remote bams).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1 Added support for legacy bucket names with mixed cases,
#2 added support for byte-rage requests that are open ended in the form of (0-) with no end-range (enables support for tools like samtools, tabix, and htslib),
#3 add support for using full s3 URLs in the form of s3.amazonaws.com/bucket_name/key providing the ability to access objects from any bucket keys have access to.