-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow layer author, comment, and created-by metadata to be set #148
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
Could you also a example in ./examples
and ideally a e2e test in ./tests
?
7c2e1e6
to
7240037
Compare
I think I've addressed all your points, but I had some trouble getting the tests to run, so I'm not certain that the new test actually passes. Hopefully I'll get time this weekend to install |
I think you can add a test such as the one added by this pr. Also, you don't really need to install podman since you would get it transparently via |
The failure I see is
Maybe it's not podman that's missing, but I need to install something to make it work. |
This fixes the "Exec format error" when running the podman tests.
Fixed. The test is working now. |
Is there anything else I need to do to this PR? |
Nothing more is actually required. |
This adds an optional
metadata
argument tobuildLayer
which allows the corresponding information strings to be set in the image history.