Skip to content

Add username chitranshi135#14

Open
chitranshi135 wants to merge 2 commits intonlok5923:mainfrom
chitranshi135:add-chitranshi135
Open

Add username chitranshi135#14
chitranshi135 wants to merge 2 commits intonlok5923:mainfrom
chitranshi135:add-chitranshi135

Conversation

@chitranshi135
Copy link

@chitranshi135 chitranshi135 commented May 30, 2021

This pr adds chitranshi135.txt file to _post folder which contains name,github username and learning objective for workshop.

Copy link
Owner

@nlok5923 nlok5923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at comments and also add description.

@chitranshi135 chitranshi135 requested a review from nlok5923 June 1, 2021 05:34
@nlok5923
Copy link
Owner

nlok5923 commented Jun 1, 2021

Also add proper pr description.

@chitranshi135
Copy link
Author

I have made the required changes.

@nlok5923
Copy link
Owner

nlok5923 commented Jun 1, 2021

@chitranshi135 you are doing well i will suggest you that you should squash your commits you can learn about squashing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants