fix(audio_osd): use percent to check volume icon#3169
Draft
jeffydc wants to merge 1 commit into
Draft
Conversation
Collaborator
|
I dont see how this would fix #3168 |
ItsLemmy
reviewed
Jun 29, 2026
1261dfd to
6fdf497
Compare
6fdf497 to
92af781
Compare
Contributor
Author
I tried to use the
Can you guide me how should I move forward? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR changes to use the
percentinstead ofvolumeto compute the volume icon.Let me know if this is not the correct direction or any further changes are required.
Motivation
fix #3168
Type of Change
Related Issue
Testing
Manual Coverage
Screenshots / Videos
From 5%:

To 0%:

Checklist
CONTRIBUTING.md.just formatwith clang-format v22+ installed, or this PR has no code changes.assets/translations/en.json, or this PR adds no new user-facing strings.Additional Notes
Ly-sec added the epsilon change in this commit. However, I couldn't find any further context so maybe he could provide additional context about that change.