feat(build): Add system_tomlplusplus option#3222
Open
carlwgeorge wants to merge 1 commit into
Open
Conversation
This allows building against the system tomlplusplus library instead of the vendored one. The option is disabled by default to retain the current vendored behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add system_tomlplusplus option to allow building against the system tomlplusplus library instead of the vendored one. The option is disabled by default to retain the current vendored behavior.
Motivation
Many distributions have guidelines/policies recommending the usage of system copies of shared libraries whenever possible.
Introducing an optional flag to build against the system shared library allows distros to use it if desired, while preserving the vendored approach otherwise.
Type of Change
Testing
I'm using a local RPM package built with this change, linked against
libtomlplusplus.so.3(tomlplusplus-3.4.0-7.fc44) in Fedora.meson testpassed during the build, and as far as I can tell everything works the same as it does without the patch.Manual Coverage
Checklist
CONTRIBUTING.md.just formatwith clang-format v22+ installed, or this PR has no code changes.assets/translations/en.json, or this PR adds no new user-facing strings.