Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IREE][EP] Add support for rocm backend #9

Merged
merged 1 commit into from
Sep 25, 2024
Merged

[IREE][EP] Add support for rocm backend #9

merged 1 commit into from
Sep 25, 2024

Conversation

Shukla-Gaurav
Copy link

This commit adds support for rocm backend in iree-ep.

Signed-Off-by: Gaurav Shukla[email protected]

zjgarvey
zjgarvey reviewed Sep 23, 2024
View reviewed changes
Copy link

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to delete the vmfb file after finishing? In the default path where save_to isn't specified, it would be nice if this vmfb gets cleaned up when no-longer necessary.

@Shukla-Gaurav
[IREE][EP] Add support for rocm backend
d948ff0 
This commit adds support for rocm backend in iree-ep.

Signed-Off-by: Gaurav Shukla<[email protected]>
@Shukla-Gaurav
Copy link
Author

@zjgarvey Thank you for reviewing, could you please take a look again?

zjgarvey
zjgarvey approved these changes Sep 25, 2024
View reviewed changes
Copy link

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good for now.

It might be nice in the future to have a provider option for keeping compilation artifacts like the imported mlir file and the compiled vmfb for debugging purposes.

@Shukla-Gaurav
Copy link
Author

I think this is good for now.

It might be nice in the future to have a provider option for keeping compilation artifacts like the imported mlir file and the compiled vmfb for debugging purposes.

yeah, will add them in my next patch. Thank you :)

@Shukla-Gaurav Shukla-Gaurav merged commit ecebd73 into nod-ai:onnxrt-rebase Sep 25, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjgarvey zjgarvey zjgarvey approved these changes

@stellaraccident stellaraccident Awaiting requested review from stellaraccident

@vinayakdsci vinayakdsci Awaiting requested review from vinayakdsci

@kumardeepakamd kumardeepakamd Awaiting requested review from kumardeepakamd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shukla-Gaurav @zjgarvey