[tuner] retire op_matchers.py through IREE python bindings #1264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangtianliu
force-pushed
the
retire_op_matcher
branch
2 times, most recently
from
a84f7f3 to
c910188
Compare
bangtianliu
force-pushed
the
retire_op_matcher
branch
from
c910188 to
8d34f9d
Compare
Max191
reviewed
Apr 15, 2025
There was a problem hiding this comment.
Nice work so far! A couple of higher level comments:
The python bindings are a bit more general than the matching we previously had, so they will be able to handle more operation types than we used to (named ops, different conv layouts, etc.). I think it is probably better to keep this PR largely NFC in terms of op support, so lets restrict the parsers to only the types of ops that we were originally supporting. Then, as a followup, support can be added for more types of contraction/convolution ops.
This way, we keep the PRs smaller, and we can land this without needing to solve any issues with additional op support.
bangtianliu
force-pushed
the
retire_op_matcher
branch
3 times, most recently
from
dc79168 to
643dc1a
Compare
bangtianliu
force-pushed
the
retire_op_matcher
branch
from
643dc1a to
3b3aee8
Compare
Max191
approved these changes
Apr 17, 2025
bangtianliu
force-pushed
the
retire_op_matcher
branch
from
84b198f to
ac6b576
Compare
Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Bangtian Liu <[email protected]>
Signed-off-by: Bangtian Liu <[email protected]>
bangtianliu
force-pushed
the
retire_op_matcher
branch
from
ac6b576 to
e7f6886
Compare
|
cc @kuhar |
kuhar
approved these changes
Apr 18, 2025
This was referenced Apr 21, 2025
bangtianliu
added a commit
that referenced
this pull request
Apr 21, 2025
Per suggestion from this comment #1264 (comment), this PR mainly removes the todo comment and adds tests for named ops. --------- Signed-off-by: Bangtian Liu <[email protected]>
bangtianliu
added a commit
that referenced
this pull request
Apr 22, 2025
As llvm/llvm-project#136054 is landed, the Python binding for `linalgOp.getIndexingMaps` can be used for tuner according to the comment #1264 (comment). Signed-off-by: Bangtian Liu <[email protected]>
IanNod
pushed a commit
to IanNod/SHARK-Platform
that referenced
this pull request
May 3, 2025
Per suggestion from this comment nod-ai#1264 (comment), this PR mainly removes the todo comment and adds tests for named ops. --------- Signed-off-by: Bangtian Liu <[email protected]>
IanNod
pushed a commit
to IanNod/SHARK-Platform
that referenced
this pull request
May 3, 2025
) As llvm/llvm-project#136054 is landed, the Python binding for `linalgOp.getIndexingMaps` can be used for tuner according to the comment nod-ai#1264 (comment). Signed-off-by: Bangtian Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR offloads the
op_matcher.pylogic to the IREE compiler through exposed python bindings as shown below:root_op_list = iree_codegen.get_tuner_root_ops(input_module)linalg::isaContractionOpInterfaceandlinalg::inferContractionDimslinalg::isaConvolutionOpInterfaceandlinalg::inferConvolutionDimsIssue:
#1110
#814
#https://github.com/nod-ai/playbook/issues/74