Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong URL for issue #49 #56

Merged
merged 2 commits into from
Dec 6, 2014
Merged

Conversation

ifraixedes
Copy link
Contributor

I've fixed wrong URL for issue #49 and replaced by anchor than a raw URL

I've fixed wrong URL for issue node-forward#49 and replaced by anchor than a raw URL
@jasonrhodes
Copy link
Contributor

Hey thanks! Did you test this change? It looks like I forgot the ".com" originally but it doesn't look like that's been added so this change may still not work.

Alternately, you could use the //#49 syntax which will auto-link.

Wanna update so I can merge? You can amend and force push your commit.

@ifraixedes ifraixedes force-pushed the patch-1 branch 2 times, most recently from 8c6e0c5 to e121044 Compare December 6, 2014 11:41
@ifraixedes
Copy link
Contributor Author

Yeah, I thought that I tested, but obviously, I didn't.
I'm trying to use the autolink, but I cannot find what I have to type, I tried with (without tildes) //#49,#49 and [#49](//#49) but they didn't work.

I don't know that it is the short version, can you tell me how?

Sorry for the silly issue.
Thanks

@jasonrhodes
Copy link
Contributor

Haha my comment got html encoded. The auto link syntax is {org or user}/{repo}/#49

@ifraixedes
Copy link
Contributor Author

I tried with that but I could make it to work; I think that it work for commit messages, issues' comments, etc, however it does not apply for Markdown docs into the repo, is it?

By the way, I updated with the absolute URL

@jasonrhodes
Copy link
Contributor

Ah that might be right, thanks!

jasonrhodes added a commit that referenced this pull request Dec 6, 2014
@jasonrhodes jasonrhodes merged commit 077f025 into node-forward:master Dec 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants