Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update package manager versions #425

Merged
merged 6 commits into from
Apr 13, 2024
Merged

Conversation

github-actions[bot]
Copy link
Contributor

This is an automated update of package manager versions

@merceyz merceyz closed this Mar 15, 2024
@merceyz merceyz reopened this Mar 15, 2024
merceyz
merceyz approved these changes Mar 15, 2024
@merceyz
Copy link
Member

merceyz commented Mar 15, 2024

We should fix the CI so we don't have to close and re-open these pull requests to get the CI to run.

@merceyz merceyz closed this Mar 15, 2024
@merceyz merceyz reopened this Mar 15, 2024
@arcanis
Copy link
Contributor

arcanis commented Mar 15, 2024

Internal Error: Error when performing the request to https://registry.yarnpkg.com/yarn/-/yarn-1.22.22.tgz; for troubleshooting help, see https://github.com/nodejs/corepack#troubleshooting

We also really should improve this error message, it's very generic.

Given that all tests are failing, perhaps there's a GitHub Actions incident?

@merceyz
Copy link
Member

merceyz commented Mar 15, 2024

That error has a cause property that contains more details but Clipanion isn't showing it, reported upstream in arcanis/clipanion#157.
Though we don't need to go through Clipanion here so we could remove it from the flow.

Given that all tests are failing, perhaps there's a GitHub Actions incident?

They're not anymore, the nocks needed to be updated.

@aduh95
Copy link
Contributor

aduh95 commented Mar 15, 2024

We should fix the CI so we don't have to close and re-open these pull requests to get the CI to run.

I don't think it's fixable, see https://docs.github.com/en/actions/security-guides/automatic-token-authentication#using-the-github_token-in-a-workflow

When you use the repository's GITHUB_TOKEN to perform tasks, events triggered by the GITHUB_TOKEN […] will not create a new workflow run. This prevents you from accidentally creating recursive workflow runs.

@merceyz
Copy link
Member

merceyz commented Mar 15, 2024

If we use a Personal Access Token or a deploy key the CI will run.

@aduh95 aduh95 enabled auto-merge (squash) April 13, 2024 14:04
@aduh95 aduh95 merged commit 1423190 into main Apr 13, 2024
10 checks passed
@aduh95 aduh95 deleted the actions/tools-update-config.json branch April 13, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants