Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more informative error when fetching latest stable fails #644

Merged
merged 11 commits into from
Feb 28, 2025

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 10, 2025

No description provided.

@aduh95 aduh95 requested a review from arcanis February 20, 2025 16:06
@aduh95
Copy link
Contributor Author

aduh95 commented Feb 28, 2025

Would like some review on the wording here please /cc @nodejs/corepack

Copy link
Contributor

@arcanis arcanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest to use UsageError, since printing a stacktrace in those errors is useless and potentially confusing (feels like an internal error rather than a user / system error).

@aduh95 aduh95 requested a review from arcanis February 28, 2025 18:51
@aduh95 aduh95 merged commit 53b1fe7 into nodejs:main Feb 28, 2025
13 checks passed
@aduh95 aduh95 deleted the fetch-latest-stable-sigerror branch February 28, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants