feat: let .corepack.env
be a lock file
#668
Open
+196
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #642 and #643 landed, we can consider using
.corepack.env
as a lockfile. If thepackage.json
defines adevEngines.packageManager
, we can accept an env variable that defines the exact version Corepack should be using; if that version is put in a.corepack.env
(Node.js 20+ users only), it's effectively a lockfile.I'm not a fan of the env variable name chosen, happy to use a different one.
Fixes: #402
Fixes: #95