-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes npm from the possible options #670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This seems to supersede and close #418
I disagree. I dont think npm has any way to manage versions per working directory like you can do with corepack.
Where was this suggestion made, and by whom? |
Then they are the best people to lobby. Corepack wasn't intended to improve their devx. Don't get me wrong, I personally think it would be a good thing for npm to leverage Corepack, but it's not my castle and I don't think Yarn and pnpm users should suffer so much delay and uncertainty because of that. Npm (and the Node TSC) will always have the ability to discuss eventual future plans through follow-ups, but they won't need me in that discussion 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My previous concerns remain, I don’t think we gain anything from it, and unless the crurent npm maintainers are asking for this, I don’t think we should do it
Can you elaborate? Why would those users suffer because of npm being available through corepack? 🤔 It would be great if you could share the context, perhaps linking to the TSC meeting notes? |
I don't think I said that? What I did say/mean is that I share the opinion that the mere presence of npm in the Corepack debate is unfortunately making it radioactive. I believe it is in part why this proposal hasn't been going anywhere despite strong repeated support from the community. I hope that by opening this PR it'll be clear that marking Corepack stable will not change anything to npm users - and perhaps quell some concerns. |
Can you provide evidence of this? Who is debating and what are they saying specifically? |
Corepack is bundled as part of Node.js distributions. It seems pretty obvious that this PR would impact NPM users in a breaking way if merged? NPM maintainer opinions on the matter seems neither here nor there - shouldn't corepack users come at priority over pleasing such external stakeholders?
By "this proposal", do you refer to dropping NPM support from corepack? From here it appears that if anything community sentiment is against and pushback has held it back? |
There 3 suggestions for Node and corepack team.
The 1st would be the best. If corepack decide not to intercept npm by default, I suggest removing npm too. Anyway, the 1st suggestion is the best, the 2nd one is second, and the 3rd one is |
Just to clarify "Remove npm" in 1 and 3 are referring to removing different things, right? As npm is not actually part of node nor corepack themselves, per se. So to spell it out more verbosely what I think you mean here:
Would that be accurate @zanminkian? (Broke apart 3 and 4 as they seem to be different points - or how would 4 depend on 3?) |
If corepack has been removed from Node in the future (nodejs/node#51981), corepack should become an independent project who aims to improve development exprerience in using package managers. At that time point, will corepack support npm? People need a tool to make life easier when using pacakge managers including npm, if corepack has been removed from Node. Corepack is a manager of package managers. Why excluding npm? Because of license or law reasons?🤔️ |
I never intended for Corepack to offer npm as an option without its maintainers enabling it themselves. It was supported through an explicit
corepack enable npm
mostly to make sure that whatever design we picked would keep npm in mind, so that in the event they'd one day be interested to join us it'd just be a flip of a switch. It wasn't a requirement (npm users already have their nice developer experience, my goal was to improve Yarn's and pnpm's devx at no cost for anyone).To clarify that and make it super duper clear that making Corepack stable won't impact npm users in any shape or form, I propose this PR to remove
npm
from the possible options. It's no longer possible to activate it usingcorepack enable npm
. I erased any mention of it, including from the tests.Also, addressing my own comment:
#418 (comment)
This was requested/suggested by TSC members unrelated to Yarn / pnpm. Since this is a Node.js project, I don't have objection to them requesting this change.
Closes #418