Skip to content

Conversation

@avivkeller
Copy link
Member

This is an alternative to #480 and #482, which just ignores all failures.

I feel that if #482 doesn't work, this is the next best option.

cc @ovflowd @flakey5 @aduh95

Copilot AI review requested due to automatic review settings November 3, 2025 22:59
@avivkeller avivkeller requested a review from a team as a code owner November 3, 2025 22:59
@vercel
Copy link

vercel bot commented Nov 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
api-docs-tooling Ready Ready Preview Nov 3, 2025 11:11pm

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 3.84615% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.93%. Comparing base (179ca04) to head (3eebf20).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/generators/legacy-html/index.mjs 3.84% 25 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #483      +/-   ##
==========================================
+ Coverage   73.86%   73.93%   +0.07%     
==========================================
  Files         109      108       -1     
  Lines       10356    10326      -30     
  Branches      686      685       -1     
==========================================
- Hits         7649     7635      -14     
+ Misses       2704     2688      -16     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller
Copy link
Member Author

To be clear, I'm not trying to invalidate the work of the other PRs by reverting it, I'm only brainstorming an alternative solution based on the fact that we are still seeing failures post #480

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the asset copying mechanism by replacing the custom safeCopy utility function with Node.js's native fs.cp() method, wrapped in a try-finally block to handle potential parallel execution conflicts.

  • Removes the custom safeCopy utility function and its file
  • Replaces safeCopy with Node.js's native fs.cp() for copying assets
  • Adds error handling via try-finally block to gracefully handle parallel execution failures

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/generators/legacy-html/utils/safeCopy.mjs Entire file removed as custom copy logic is no longer needed
src/generators/legacy-html/index.mjs Replaced safeCopy with native fs.cp() and added try-finally block for parallel execution safety

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Change finally block to catch block to handle potential failures gracefully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants